Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: static webapp path #2931

Merged
merged 25 commits into from
Feb 27, 2025
Merged

fix: static webapp path #2931

merged 25 commits into from
Feb 27, 2025

Conversation

heimwege
Copy link
Contributor

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 0f31b39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/mockserver-config-writer Patch
@sap-ux/odata-service-writer Patch
@sap-ux/adp-tooling Patch
@sap-ux/telemetry Patch
@sap-ux/create Patch
@sap-ux/i18n Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/inquirer-common Patch
@sap-ux/ui5-library-reference-sub-generator Patch
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/fe-fpm-writer Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/project-access Patch
@sap-ux/app-config-writer Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/cap-config-writer Patch
@sap-ux/deploy-config-generator-shared Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/annotation-generator Patch
@sap-ux/cards-editor-middleware Patch
@sap-ux/cf-deploy-config-writer Patch
@sap-ux/environment-check Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/launch-config Patch
@sap-ux/project-integrity Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/fe-fpm-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heimwege heimwege added odata-service-writer @sap-ux/odata-servier-writer mockserver-config-writer @sap-ux/mockserver-config-writer adp-tooling telemetry @sap-ux/telemetry labels Feb 17, 2025
@heimwege heimwege marked this pull request as ready for review February 18, 2025 07:04
@heimwege heimwege requested review from a team as code owners February 18, 2025 07:04
@heimwege heimwege requested a review from broksy February 18, 2025 07:09
@heimwege heimwege added the create @sap-ux/create label Feb 18, 2025
broksy
broksy previously approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@broksy broksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for @sap-ux/mockserver-config-writer and @sap-ux/odata-service-writer looks good from my side.
Changeset corresponds to the changes. Approved.

devinea
devinea previously approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are clear.
assumed covered by tests
changeset ✅

johannes-kolbe
johannes-kolbe previously approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@johannes-kolbe johannes-kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Focus on create, reusing refactored method lg
  • test snapshots show improved webapp path
  • changeset provided
  • Did not test manually

mmilko01

This comment was marked as duplicate.

Sign in to view

mmilko01
mmilko01 previously approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@mmilko01 mmilko01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset OK
Code coverage is good
Comments addressed
Tested manually by team QA

@johannes-kolbe
Copy link
Contributor

@heimwege merge issues currently

@heimwege
Merge branch 'main' of github.com:SAP/open-ux-tools into fix/2589/sta…
8d9ca24 
…tic-webapp-path

# Conflicts:
#	packages/adp-tooling/src/base/helper.ts
#	packages/adp-tooling/test/unit/preview/adp-preview.test.ts
@heimwege
Copy link
Contributor Author

@heimwege merge issues currently

fixed. Thanks for the hint

@heimwege heimwege requested a review from mmilko01 February 26, 2025 15:13
johannes-kolbe
johannes-kolbe previously approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@johannes-kolbe johannes-kolbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving

mmilko01
mmilko01 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@mmilko01 mmilko01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

devinea
devinea approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

unseen1980
unseen1980 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@unseen1980 unseen1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. Thanks

@heimwege heimwege merged commit 4b8577f into main Feb 27, 2025
16 checks passed
@heimwege heimwege deleted the fix/2589/static-webapp-path branch February 27, 2025 14:09
@heimwege heimwege mentioned this pull request Feb 27, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unseen1980 unseen1980 unseen1980 approved these changes

@devinea devinea devinea approved these changes

@johannes-kolbe johannes-kolbe johannes-kolbe approved these changes

@mmilko01 mmilko01 mmilko01 approved these changes

@broksy broksy Awaiting requested review from broksy

@Klaus-Keller Klaus-Keller Awaiting requested review from Klaus-Keller

Assignees
No one assigned
Labels
adp-tooling create @sap-ux/create mockserver-config-writer @sap-ux/mockserver-config-writer odata-service-writer @sap-ux/odata-servier-writer telemetry @sap-ux/telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@heimwege @mmilko01 @johannes-kolbe @unseen1980 @devinea @Klaus-Keller @broksy